Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wireshark.vm] Add tshark to PATH and Tools dir #1235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Jan 10, 2025

Wireshark installs tshark, but it was not added to PATH. Add it to PATH and to the Tools directory to make it easier to find.

@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label Jan 10, 2025
@Ana06 Ana06 requested a review from sara-rn January 10, 2025 17:44
@Ana06 Ana06 self-assigned this Jan 10, 2025
Copy link
Contributor

@sara-rn sara-rn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, everything looks good. I just added a minor comment regarding the shortcut

packages/wireshark.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
Wireshark installs tshark, but it was not added to PATH. Add it to PATH
and to the Tools directory to make it easier to find.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants